the-other-tim-brown commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2638280472
##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -746,6 +746,48 @@ public void testIcebergCorruptedSnapshotRecovery() throws
Exception {
}
}
+ @Test
+ public void testColumnMappingEnabledDeltaToIceberg() {
+ String tableName = getTableName();
+ ConversionSourceProvider<?> conversionSourceProvider =
getConversionSourceProvider(DELTA);
+ try (TestSparkDeltaTable table =
+ TestSparkDeltaTable.forColumnMappingEnabled(tableName, tempDir,
sparkSession, null)) {
+ table.insertRows(20);
+ ConversionController conversionController =
+ new ConversionController(jsc.hadoopConfiguration());
+ ConversionConfig conversionConfig =
+ getTableSyncConfig(
+ DELTA,
+ SyncMode.INCREMENTAL,
+ tableName,
+ table,
+ Collections.singletonList(ICEBERG),
+ null,
+ null);
+ conversionController.sync(conversionConfig, conversionSourceProvider);
+ table.insertRows(10);
+ conversionController.sync(conversionConfig, conversionSourceProvider);
+ table.insertRows(10);
+ conversionController.sync(conversionConfig, conversionSourceProvider);
+ checkDatasetEquivalence(DELTA, table,
Collections.singletonList(ICEBERG), 40);
+
+ table.dropColumn("long_field");
+ table.insertRows(10);
+ conversionController.sync(conversionConfig, conversionSourceProvider);
+ checkDatasetEquivalence(DELTA, table,
Collections.singletonList(ICEBERG), 50);
+
+ table.renameColumn("double_field", "scores");
Review Comment:
Thanks for confirming!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
