Multi-subproject patches used to work. If they don't work now, it is probably a bug in test-patch.sh that we should fix. The code there is written expecting multi-project changes, but maybe it doesn't get much of a workout normally.
Conceptually, I think it's important to support patches that modify multiple sub-projects. Otherwise refactoring things in common becomes a multi-step process. You can't very well change an API in hadoop-common that multiple projects are using with patches that touch only one subproject, unless you use a cumbersome "deprecate and then remove" process. This just slows down development and doesn't really seem to have any upside. I also think it makes sense to have discussion about a change in Hadoop-common all in one place, rather than splitting it into multiple discussions on multiple per-subproject JIRAs. best, Colin On Tue, Nov 18, 2014 at 2:24 PM, Chris Nauroth <cnaur...@hortonworks.com> wrote: > That's an interesting find. This has not always been the case. In the > past, we've provided consolidated patches on a HADOOP jira to get > pre-commit coverage when changes span multiple sub-projects. Yongjun, if > you haven't already done so, I suggest filing a jira for this. > > Chris Nauroth > Hortonworks > http://hortonworks.com/ > > > On Sat, Nov 15, 2014 at 8:19 AM, Yongjun Zhang <yzh...@cloudera.com> > wrote: > > > For all's info, confirmed what Ray stated, indeed it's the reason! > > > > Thanks. > > > > --Yongjun > > > > > > On Fri, Nov 14, 2014 at 2:40 PM, Yongjun Zhang <yzh...@cloudera.com> > > wrote: > > > > > Many thanks Ray, good to know! > > > > > > --Yongjun > > > > > > On Fri, Nov 14, 2014 at 2:03 PM, Ray Chiang <rchi...@cloudera.com> > > wrote: > > > > > >> Your patch covers multiple projects (I see 81 files across > > >> hadoop-common-project, hadoop-hdfs-project, hadoop-mapreduce-project, > > >> hadoop-tools, hadoop-yarn-project). > > >> > > >> Jenkins had problems with that for me a few months back. If you break > > it > > >> up per-project, it should work just fine. > > >> > > >> -Ray > > >> > > >> > > >> On Fri, Nov 14, 2014 at 1:49 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > >> > > >> > Adding builds@apache > > >> > > > >> > On Fri, Nov 14, 2014 at 1:34 PM, Yongjun Zhang <yzh...@cloudera.com > > > > >> > wrote: > > >> > > > >> > > Hi, > > >> > > > > >> > > One issue to report here, any help would be greatly appreciated! > > >> > > > > >> > > I noticed that multiple patch submissions to > > >> > > https://issues.apache.org/jira/browse/HADOOP-11293 > > >> > > did not trigger jenkins test run. > > >> > > > > >> > > Thanks Chris Nauroth for the help to trigger one manually for me: > > >> > > > > >> > > https://builds.apache.org/job/PreCommit-HADOOP-Build/5079/ > > >> > > > > >> > > and it turned out the manually triggered one did not report result > > >> back > > >> > to > > >> > > the jira upon finishing. > > >> > > > > >> > > I submitted the same patch to another jira (HADOOP-11045) that I > was > > >> > > working on, which triggered jenkins test before, and it seems not > > >> > > triggering this time too. > > >> > > > > >> > > So it looks like something is broken. This might be just a HADOOP > > jira > > >> > > issue (HDFS jira seems to be fine). > > >> > > > > >> > > Thanks a lot for looking into. > > >> > > > > >> > > --Yongjun > > >> > > > > >> > > > >> > > > > > > > > > > -- > CONFIDENTIALITY NOTICE > NOTICE: This message is intended for the use of the individual or entity to > which it is addressed and may contain information that is confidential, > privileged and exempt from disclosure under applicable law. If the reader > of this message is not the intended recipient, you are hereby notified that > any printing, copying, dissemination, distribution, disclosure or > forwarding of this communication is strictly prohibited. If you have > received this communication in error, please contact the sender immediately > and delete it from your system. Thank You. >
