> On Mar 22, 2016, at 6:46 PM, Gangumalla, Uma <[email protected]> wrote:
>
>> is it possible for me to setup a branch, self review+commit to that
>> branch, then request a branch merge?
> Basically this is something like Commit-Then-Review(here review later)
> process right. I have not seen we followed this approach here( not sure if
> I missed some branches followed that).
At least in recent times, YARN-3368 attempted to do that with the merge
request found in YARN-4734. The first or second commit that went into that
branch clearly has never been reviewed by another committer. Since a PMC
member did the commit and merge request, I thought I’d ask since it implies
that the policy really is CTR for merge requests. (FWIW, I was the lone -1 on
the merge request, otherwise it likely would have gone in given it already had
2 +1’s despite a) breaking the build b) having significant license issues and
c) no design doc.)
