ayushtkn commented on a change in pull request #8:
URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492300681
##########
File path: pom.xml
##########
@@ -95,6 +95,7 @@
<shaded.prefix>org.apache.hadoop.thirdparty</shaded.prefix>
<protobuf.shade.prefix>${shaded.prefix}.protobuf</protobuf.shade.prefix>
<protobuf_3_7.version>3.7.1</protobuf_3_7.version>
+ <guava.version>27.0-jre</guava.version>
Review comment:
upgraded to 29.0-jre
##########
File path: hadoop-shaded-guava/pom.xml
##########
@@ -0,0 +1,125 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <artifactId>hadoop-thirdparty</artifactId>
+ <groupId>org.apache.hadoop.thirdparty</groupId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>hadoop-shaded-guava</artifactId>
+ <name>Apache Hadoop shaded Guava</name>
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <exclusions>
Review comment:
I excluded these following the way hbase did it, so that they can be
directly added to the project.
Ref -
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
But I think, we can avoid excluding them and remove the exclusions block. if
anything required to get excluded, that can be done when adding this as
dependency in the main project. Thoughts?
##########
File path: hadoop-shaded-guava/pom.xml
##########
@@ -0,0 +1,125 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <artifactId>hadoop-thirdparty</artifactId>
+ <groupId>org.apache.hadoop.thirdparty</groupId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>hadoop-shaded-guava</artifactId>
+ <name>Apache Hadoop shaded Guava</name>
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <exclusions>
Review comment:
I excluded these following the way hbase did it, so that they can be
directly added to the project.
Ref -
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
But I think, we can avoid excluding them and remove the exclusions
block.There is no harm, if they are not excluded IMO. I have pushed a change
removing the exclusions, let me know if that makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org
