[
https://issues.apache.org/jira/browse/HADOOP-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735552#action_12735552
]
rahul k singh commented on HADOOP-6105:
---------------------------------------
Changes look good ,
some minor comments:
Configuration.java
1.Check for null in addDeprecation method.
2.Some extra lines are there in front of some of the methods , remove them
3.Try to use foreach kind of syntax where ever possible.It makes code look
simpler.
TestConfiguration.java
1.In tearDown method , you should delete the test-config.xml file also
2.make sure that CONFIG3 is deleted.
1.Diff has Index: junitvmwatcher8758949811953274592.properties
I dont think it is required.
Diff also has test-config3.xml
i think this is becoz of CONFIG3 not being deleted in testcase.
> Provide a way to automatically handle backward compatibility of deprecated
> keys
> -------------------------------------------------------------------------------
>
> Key: HADOOP-6105
> URL: https://issues.apache.org/jira/browse/HADOOP-6105
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Hemanth Yamijala
> Attachments: HADOOP-6105.patch
>
>
> There are cases when we have had to deprecate configuration keys. Use cases
> include, changing the names of variables to better match intent, splitting a
> single parameter into two - for maps, reduces etc.
> In such cases, we typically provide a backwards compatible option for the old
> keys. The handling of such cases might typically be common enough to actually
> add support for it in a generic fashion in the Configuration class. Some
> initial discussion around this started in HADOOP-5919, but since the project
> split happened in between we decided to open this issue to fix it in common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
