[
https://issues.apache.org/jira/browse/HADOOP-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739933#action_12739933
]
Sreekanth Ramakrishnan commented on HADOOP-6105:
------------------------------------------------
Took a look at the patch file:
The code changes looks fine. Following are the comments with respect to test
case:
In testcase do assert that get of the old and new key matches correctly. We
just need to do the following for these cases.
Old final new final --- Old.
old non-final new final --- New
old final new non-final -- Old
old non-final new non-final -- Old
Add test case to check user code case also, i.e the configuration resource has
only new keys. Then you can add deprecated keys using addDeprecation and then
do get set and get of old keys.
> Provide a way to automatically handle backward compatibility of deprecated
> keys
> -------------------------------------------------------------------------------
>
> Key: HADOOP-6105
> URL: https://issues.apache.org/jira/browse/HADOOP-6105
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Hemanth Yamijala
> Attachments: HADOOP-6105-1.patch, HADOOP-6105.patch, HADOOP-6105.patch
>
>
> There are cases when we have had to deprecate configuration keys. Use cases
> include, changing the names of variables to better match intent, splitting a
> single parameter into two - for maps, reduces etc.
> In such cases, we typically provide a backwards compatible option for the old
> keys. The handling of such cases might typically be common enough to actually
> add support for it in a generic fashion in the Configuration class. Some
> initial discussion around this started in HADOOP-5919, but since the project
> split happened in between we decided to open this issue to fix it in common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
