[
https://issues.apache.org/jira/browse/HADOOP-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745379#action_12745379
]
Hemanth Yamijala commented on HADOOP-6184:
------------------------------------------
- updatingResouce need not be static. Also, I think it should not be created
unless the flag to store resources is set to true.
- Leave a space between control statement (like if) and the condition
- Rename writeJson to dumpConfiguration. Document in writeJson that it will not
work if configuration is loaded from the an input stream. Update documentation
to say the format in which the dump is generated. It would also be good to
document the format itself as an example.
- Why is flush called after each item written ? Can it be done only once ?
- Should handle the case where default resources are not loaded. When a
configuration object is cloned in writeJson, it loses knowledge of whether
default resources were loaded with the original config being dumped or not.
- Testcase:
-- the writers created should be closed.
-- the way we are looking up for the key from the json properties can do with
some improvement. Can't we build a hashtable once the deserialization happens
and do a lookup ?
> Provide a configuration dump in json format.
> --------------------------------------------
>
> Key: HADOOP-6184
> URL: https://issues.apache.org/jira/browse/HADOOP-6184
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: rahul k singh
> Assignee: V.V.Chaitanya Krishna
> Attachments: HADOOP-6184-1.patch, HADOOP-6184-2.patch,
> HADOOP-6184-3.patch, HADOOP-6184-4.patch, HADOOP-6184.patch
>
>
> Configuration dump in json format.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
