[
https://issues.apache.org/jira/browse/HADOOP-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745878#action_12745878
]
Hemanth Yamijala commented on HADOOP-6184:
------------------------------------------
- The commit of HADOOP-6103 ensured that the loadDefaults variable is being
cloned in the copy constructor. So, it can be removed from the private
constructor you are introducing.
bq. the writers created should be closed.
- I meant the BufferedWriter to be closed in the testcase, not the StringWriter.
- Also for the test case related to default resources, I think we should
ideally have that in a separate test case. And it should make sure that the
default size of the json properties is 0. Then we can add a new resource that
adds a couple of strings and makes sure those alone are dumped.
> Provide a configuration dump in json format.
> --------------------------------------------
>
> Key: HADOOP-6184
> URL: https://issues.apache.org/jira/browse/HADOOP-6184
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: rahul k singh
> Assignee: V.V.Chaitanya Krishna
> Attachments: HADOOP-6184-1.patch, HADOOP-6184-2.patch,
> HADOOP-6184-3.patch, HADOOP-6184-4.patch, HADOOP-6184-5.patch,
> HADOOP-6184-6.patch, HADOOP-6184.patch
>
>
> Configuration dump in json format.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
