[
https://issues.apache.org/jira/browse/HADOOP-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791250#action_12791250
]
Suresh Srinivas commented on HADOOP-6394:
-----------------------------------------
Comments:
# There are some empty line changes, can you please remove them
# There are some lines longer than 80 columns
# FileContextCreateMkdirBaseTest.java - Use shortened path to Log4JLogger
# FileContextURIBase.java - Add a method setup as in other base tests with
@Before annotation to fix the warning in class javadoc
# When using FileContextTestHelper, do a static import to avoid having to call
methods using FileContextHelper class prefix.
# FileContextTestHelper - pass the block size also as CreateOpts to FileContext
create method.
# FileContextTestHelper - make defaultBlockSize and defaultNumBlocks final
# FileContextTestHelper - make the class final and add a private constructor
# FileContextTestHelper.getTestRoot() - rootPath should be created always as
different tests could use different FileContexts.
# FileContextMainOperationsBaseTest.testWriteInNonExistentDirectory - not sure
why this throws InterruptedException. There are other methods throwing
InterruptedException as well
> Helper class for FileContext tests
> ----------------------------------
>
> Key: HADOOP-6394
> URL: https://issues.apache.org/jira/browse/HADOOP-6394
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6394.1.patch, HADOOP-6394.2.patch,
> HADOOP-6394.3.patch
>
>
> A helper class for FileContext tests should contain common methods which
> can be used in many unit tests, so that every unit test doesn't have to
> re-implement these functionality.
> Examples of such methods:
> createFile(FileContext fc, Path path, int numBlocks, int blockSize) //To
> create a file with number of blocks and block-size passed.
> getTestRootPath(FileContext fc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
