[ 
https://issues.apache.org/jira/browse/HADOOP-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791573#action_12791573
 ] 

Aaron Kimball commented on HADOOP-6420:
---------------------------------------

Fair point. I think that the semantics of (A) are clearer. I will modify 
MAPREDUCE-1126 to use external sentinel values.

As for your other v8 issues

1) Good call on {{equals()}}
2) {{Configuration.this.get()}} will use deprecation-resolution on the provided 
key. Deprecation-resolution is handled at the map key (prefix) level, not on 
individual subkeys within the map. So those should not call {{get()}}.
3) Yes.
4) This can be added.
5) I don't see what you mean. If {{Configuration.this.get()}} is used or the 
current {{Configuration.this.getProps()}}, you still need a 
{{Configuration.this}} associated with it, so you can't use a static inner 
class. You could conceivably hold an explicit reference to the 
{{Configuration}} object, but given that the implicit reference is the whole 
point of a non-static inner class, I don't see what using a static class buys 
us.


> String-to-String Maps should be embeddable in Configuration
> -----------------------------------------------------------
>
>                 Key: HADOOP-6420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6420
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: HADOOP-6420.2.patch, HADOOP-6420.3.patch, 
> HADOOP-6420.4.patch, HADOOP-6420.5.patch, HADOOP-6420.6.patch, 
> HADOOP-6420.7.patch, HADOOP-6420.8.patch, HADOOP-6420.patch
>
>
> Per MAPREDUCE-1126, we need to be able to take a map of (key, value) pairs 
> and embed that inside a Configuration object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to