[
https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898462#action_12898462
]
Luke Lu commented on HADOOP-6884:
---------------------------------
bq. Leaving out test code doesn't change the situation.
Why? It would make the patches smaller and quicker to review.
bq. build time - means we wouldn't be able to enable debug at runtime, that's a
significant restriction compared to current state and limits troubleshooting
capabilities.
AOP can insert if LOG.isDebugEnabled()) guards at build time, so you can
definitely enable debug at runtime.
The problem with the current approach is that you'd have to keep patching
people's new code manually.
> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
> Key: HADOOP-6884
> URL: https://issues.apache.org/jira/browse/HADOOP-6884
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Erik Steffl
> Assignee: Erik Steffl
> Fix For: 0.22.0
>
> Attachments: HADOOP-6884-0.22-1.patch, HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is
> true, in some cases it's expensive to construct the string that is being
> printed to log. It's much easier to always use LOG.isDebugEnabled() because
> it's easier to check (rather than in each case reason whether it's necessary
> or not).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
