[ https://issues.apache.org/jira/browse/HADOOP-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095332#comment-15095332 ]
Kai Zheng commented on HADOOP-12662: ------------------------------------ bq. Perhaps we should open a follow-on jira to split this out into a separate bash file, which would be a bit cleaner. Yeah. I didn't make the change in the patch because after some trying it was found doing so involves change in bigger scope and better to be further discussed separately. I will create the issue to follow on this. > The build should fail if a -Dbundle option fails > ------------------------------------------------ > > Key: HADOOP-12662 > URL: https://issues.apache.org/jira/browse/HADOOP-12662 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Kai Zheng > Assignee: Kai Zheng > Attachments: HADOOP-12662-v1.patch, HADOOP-12662-v2.patch, > HADOOP-12662-v3.patch, HADOOP-12662-v4.patch > > > Per some discussion with [~cmccabe], it would be good to refine and make it > consistent the behaviors in bundling native libraries when building dist > package. > For all native libraries to bundle, if the bundling option like > {{-Dbundle.snappy}} is specified, then the lib option like {{-Dsnappy.lib}} > will be checked and ensured to be there, but if not, it will then report > error and fail the building explicitly. > {{BUILDING.txt}} would also be updated to explicitly state this behavior. -- This message was sent by Atlassian JIRA (v6.3.4#6332)