[ https://issues.apache.org/jira/browse/HADOOP-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073311#comment-15073311 ]
Kai Zheng commented on HADOOP-12662: ------------------------------------ Thanks [~aw] for the great comments! bq. significantly less painful since the X is no longer needed. I see. Maybe we could keep it as someone like me is used to the style? bq. Once you set a bash option, ..., It sounds good to me to set it at the beginning thus it will be easier for the simple script. > The build should fail if a -Dbundle option fails > ------------------------------------------------ > > Key: HADOOP-12662 > URL: https://issues.apache.org/jira/browse/HADOOP-12662 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Kai Zheng > Assignee: Kai Zheng > Attachments: HADOOP-12662-v1.patch, HADOOP-12662-v2.patch, > HADOOP-12662-v3.patch > > > Per some discussion with [~cmccabe], it would be good to refine and make it > consistent the behaviors in bundling native libraries when building dist > package. > For all native libraries to bundle, if the bundling option like > {{-Dbundle.snappy}} is specified, then the lib option like {{-Dsnappy.lib}} > will be checked and ensured to be there, but if not, it will then report > error and fail the building explicitly. > {{BUILDING.txt}} would also be updated to explicitly state this behavior. -- This message was sent by Atlassian JIRA (v6.3.4#6332)