[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097278#comment-15097278 ]
Colin Patrick McCabe commented on HADOOP-8887: ---------------------------------------------- bq. Rather than hardcoding 4, we could use this Java API to get the # of processors: https://docs.oracle.com/javase/7/docs/api/java/lang/Runtime.html#availableProcessors() Cool. I didn't know this API existed... will add. bq. Nit: validateSourceParams, switch the order of arguments? Left to right I'd normally read input then output. OK. bq. Would be good to update BUILDING.txt with your "-DallNative" and "-Dtest_bulk_crc32" invocations as documentation Added > Use a Maven plugin to build the native code using CMake > ------------------------------------------------------- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build > Affects Versions: 2.0.3-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch, HADOOP-8887.013.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)