[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098770#comment-15098770
]
Andrew Wang commented on HADOOP-8887:
-------------------------------------
There's a bunch of checkstyle stuff, and findbugs looks like it's broken
because of some kafka stuff.
CC warnings, I'm guessing you're handling at HADOOP-12712 which I'll review.
Overall it seems okay, it's just there's a lot more "-1" than I'm used to in a
precommit run, and it's not just flaky unit tests. The whitespace/checkstyle
stuff is onerous, but one more precommit run will fix it.
If you want to take care of all this in HADOOP-12712, I'm okay with that.
Nothing functionally wrong in what was committed, so okay to do it in a
follow-on.
> Use a Maven plugin to build the native code using CMake
> -------------------------------------------------------
>
> Key: HADOOP-8887
> URL: https://issues.apache.org/jira/browse/HADOOP-8887
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 2.0.3-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.9.0
>
> Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
> HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch,
> HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch,
> HADOOP-8887.012.patch, HADOOP-8887.013.patch, HADOOP-8887.014.patch
>
>
> Currently, we build the native code using ant-build invocations. Although
> this works, it has some limitations:
> * compiler warning messages are hidden, which can cause people to check in
> code with warnings unintentionally
> * there is no framework for running native unit tests; instead, we use ad-hoc
> constructs involving shell scripts
> * the antrun code is very platform specific
> * there is no way to run a specific native unit test
> * it's more or less impossible for scripts like test-patch.sh to separate a
> native test failing from the build itself failing (no files are created) or
> to enumerate which native tests failed.
> Using a native Maven plugin would overcome these limitations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
