[ 
https://issues.apache.org/jira/browse/HADOOP-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183354#comment-15183354
 ] 

Allen Wittenauer commented on HADOOP-12892:
-------------------------------------------

{code}
                        if [[ "${bundle.snappy.in.bin}" == "true" ]]; then
                          if [[ "${bundle.snappy}" == "true" ]]; then
                            cd "${snappy.lib}"
                            $$TAR *snappy* | (cd $${TARGET_BIN_DIR}/; $$UNTAR)
                            if [[ $? -ne 0 ]]; then
                              echo "Bundling snappy bin files failed"
                              exit 1
                            fi
                          fi
{code}

Ping [~cnauroth].  I have a question about the logic here...

Why does this cd to snappy.lib and copy the contents into bin when all those 
bits should have already been copied as part of the bundle.snappy into the lib 
directory? This seems to imply that on Windows (which appears to be the only 
place this is used), the libraries have been copied to two different 
directories...

> fix/rewrite create-release
> --------------------------
>
>                 Key: HADOOP-12892
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12892
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>
> create-release needs some major surgery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to