[ 
https://issues.apache.org/jira/browse/HADOOP-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183433#comment-15183433
 ] 

Chris Nauroth commented on HADOOP-12892:
----------------------------------------

[~aw], yes, this is Windows-specific logic.  Windows wants DLLs to be in bin 
instead of the standard lib directory structure.  On Windows, the native build 
artifacts get placed into a bin sub-directory as part of the hadoop-common 
build.  The hadoop-common pom.xml also sets bundle.snappy.in.bin to true, so 
that later the distro knows snappy.dll needs to go here.

bq. This seems to imply that on Windows (which appears to be the only place 
this is used), the libraries have been copied to two different directories...

I don't think so, because there are {{-d}} checks to trigger the copies only if 
the directories exist.  On Windows, {{LIB_DIR}} will not exist and {{BIN_DIR}} 
will exist, so it will only do the copy for {{BIN_DIR}}.  On non-Windows, 
{{LIB_DIR}} will exist and {{BIN_DIR}} will not exist, so it will only do the 
copy for {{LIB_DIR}}.

BTW, it looks like lifting out the dist-layout-stitching script to an external 
file on trunk isn't working for Windows.  I filed HADOOP-12899, and I'll take a 
closer look.


> fix/rewrite create-release
> --------------------------
>
>                 Key: HADOOP-12892
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12892
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>
> create-release needs some major surgery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to