[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238366#comment-15238366 ]
Kai Zheng commented on HADOOP-12924: ------------------------------------ Thanks [~lirui] for the nice work. 1. In {{CodecUtil}}, I guess we can always assert conf != null to simplify the codes. 2. Maybe we can add {{getCodec}} method to {{ErasureCodingPolicy}}, as minor. 3. I don't think we have to set the codec property to {{conf}} in HH and test related codes, as they can use the default one. 4. Would be good to add a new test to check all of these {{codecName->coder}} mappings. > Add default coder key for creating raw coders > --------------------------------------------- > > Key: HADOOP-12924 > URL: https://issues.apache.org/jira/browse/HADOOP-12924 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Rui Li > Assignee: Rui Li > Priority: Minor > Labels: hdfs-ec-3.0-must-do > Attachments: HADOOP-12924.1.patch, HADOOP-12924.2.patch, > HADOOP-12924.3.patch > > > As suggested > [here|https://issues.apache.org/jira/browse/HADOOP-12826?focusedCommentId=15194402&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15194402]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)