[
https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238526#comment-15238526
]
Rui Li commented on HADOOP-12924:
---------------------------------
Thanks [~drankye] for the review!
1. Actually I do get NPEs in tests if I don't check whether conf is null.
2. Yes will do.
3. I think you mean the changes in {{TestHHXORErasureCoder}} and
{{TestRSErasureCoder}}? They're just renames because we have renamed the raw
coder config keys. And it's not configuring the codec but raw coder. Anyway
like you said, if we don't set those configs, we'll be using the default ones.
Do you think we should remove them?
4. Could you elaborate on what check should be done?
> Add default coder key for creating raw coders
> ---------------------------------------------
>
> Key: HADOOP-12924
> URL: https://issues.apache.org/jira/browse/HADOOP-12924
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Rui Li
> Assignee: Rui Li
> Priority: Minor
> Labels: hdfs-ec-3.0-must-do
> Attachments: HADOOP-12924.1.patch, HADOOP-12924.2.patch,
> HADOOP-12924.3.patch
>
>
> As suggested
> [here|https://issues.apache.org/jira/browse/HADOOP-12826?focusedCommentId=15194402&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15194402].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
