[ 
https://issues.apache.org/jira/browse/HADOOP-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416068#comment-15416068
 ] 

Chris Nauroth commented on HADOOP-13446:
----------------------------------------

bq. Chris Nauroth for the mvn behavior changes you mention, do those only 
affect build/test at the hadoop-aws level, or do they impact top-level builds? 
Seems like the former but making sure.

Good question!  This only impacts the hadoop-aws level.  Only hadoop-aws tests 
will be using the verify phase via the failsafe plugin.  (Maybe other modules 
will start doing it someday if they have a use case, but that would happen 
independent of this patch.)

Another consideration is Yetus pre-commit.  That has support for running 
parallel tests by passing {{-Pparallel-tests}}.  That's fine though, because 
pre-commit only runs the test phase, not the verify phase, and passing 
{{-Pparallel-tests}} works well for just the unit tests.  To summarize, there 
is no harm done to pre-commit.

> S3Guard: Support running isolated unit tests separate from AWS integration 
> tests.
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-13446
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13446
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-13446-HADOOP-13345.001.patch, 
> HADOOP-13446-HADOOP-13345.002.patch
>
>
> Currently, the hadoop-aws module only runs Surefire if AWS credentials have 
> been configured.  This implies that all tests must run integrated with the 
> AWS back-end.  It also means that no tests run as part of ASF pre-commit.  
> This issue proposes for the hadoop-aws module to support running isolated 
> unit tests without integrating with AWS.  This will benefit S3Guard, because 
> we expect the need for isolated mock-based testing to simulate eventual 
> consistency behavior.  It also benefits hadoop-aws in general by allowing 
> pre-commit to do something more valuable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to