[
https://issues.apache.org/jira/browse/HADOOP-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468016#comment-15468016
]
Masatake Iwasaki commented on HADOOP-13579:
-------------------------------------------
{noformat}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:215:
final public static void setPingInterval(Configuration conf, int
pingInterval) {:9: 'public' modifier out of order with the JLS suggestions.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:226:
final public static int getPingInterval(Configuration conf) {:9: 'public'
modifier out of order with the JLS suggestions.
{noformat}
checkstyle suggests {{public static final}} rather than {{final public static}}.
There seems to be deadlock in {{TestConfiguration.testConcurrentAccesses}} even
without the patch. It should be addressed in another jira.
I'm +1 on 002 if the checkstyle issues are addressed.
> Fix source-level compatibility after HADOOP-11252
> -------------------------------------------------
>
> Key: HADOOP-13579
> URL: https://issues.apache.org/jira/browse/HADOOP-13579
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.7.3, 2.6.4
> Reporter: Akira Ajisaka
> Assignee: Tsuyoshi Ozawa
> Priority: Blocker
> Attachments: HADOOP-13579-branch-2.6.001.patch,
> HADOOP-13579-branch-2.6.002.patch, HADOOP-13579-branch-2.7.001.patch,
> HADOOP-13579-branch-2.7.002.patch
>
>
> Reported by [~chiwanpark]
> bq. Since 2.7.3 release, Client.get/setPingInterval is changed from public to
> package-private.
> bq. Giraph is one of broken examples for this changes.
> (https://github.com/apache/giraph/blob/release-1.0/giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java#L202)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
