[
https://issues.apache.org/jira/browse/HADOOP-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469245#comment-15469245
]
Masatake Iwasaki commented on HADOOP-13579:
-------------------------------------------
bq. changes to existing code: maintains existing style
I think we should address checkstyle warnings about coding style here. If the
Client.java is consistent in coding style, we should keep it based on the above
statement but it is not. Client.java has both {{final public static}} and
{{public static final}}. Majority of the declarations keeps modifier order
recommended by JLS.
> Fix source-level compatibility after HADOOP-11252
> -------------------------------------------------
>
> Key: HADOOP-13579
> URL: https://issues.apache.org/jira/browse/HADOOP-13579
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.7.3, 2.6.4
> Reporter: Akira Ajisaka
> Assignee: Tsuyoshi Ozawa
> Priority: Blocker
> Attachments: HADOOP-13579-branch-2.6.001.patch,
> HADOOP-13579-branch-2.6.002.patch, HADOOP-13579-branch-2.7.001.patch,
> HADOOP-13579-branch-2.7.002.patch
>
>
> Reported by [~chiwanpark]
> bq. Since 2.7.3 release, Client.get/setPingInterval is changed from public to
> package-private.
> bq. Giraph is one of broken examples for this changes.
> (https://github.com/apache/giraph/blob/release-1.0/giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java#L202)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
