[ 
https://issues.apache.org/jira/browse/HADOOP-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602745#comment-15602745
 ] 

Lei (Eddy) Xu commented on HADOOP-13449:
----------------------------------------

bq. . I'm wondering whether we should also save access time, owner, group, 
permission, size etc in the metadata,

Yes, in theory, we can save them. However, for S3AFileStatus, these fields are 
not set, while the tests are not test the special cases of S3AFIleStatus (i.e., 
whether {{isEmptyDirectory() == true && DirMetadata.isEmpty()}} ).   IMO, we 
should modify the tests for these invariants. 


I am working on reviewing the rest of the patch. Will post a review soon. 
Thanks for the good work.




> S3Guard: Implement DynamoDBMetadataStore.
> -----------------------------------------
>
>                 Key: HADOOP-13449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13449
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-13449-HADOOP-13345.000.patch
>
>
> Provide an implementation of the metadata store backed by DynamoDB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to