[
https://issues.apache.org/jira/browse/HADOOP-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603207#comment-15603207
]
Lei (Eddy) Xu commented on HADOOP-13449:
----------------------------------------
Hi, [~liuml07]
The patch looks good to me overall. Looking forward to fill the gaps of tests.
{code:title=PathMetadataToDynamoDBTranslation.java}
final FileStatus fileStatus = isDir ? new S3AFileStatus(true, false, path) :
new S3AFileStatus(0, 0, path, 0);
{code}
Here, it seems that it only has the path be correctly populated. It assumes
that {{S3AFileSystem}} only checks the existence of file in {{MS}}. It is
different to {{InMemoryMetadataStore}}. I feel that we should have a consistent
contract for all the stores.
* Regarding {{isEmptyDirectory}}. should we store it in dynamodb as well? The
drawback is that we should update this field in DynamoDB in
{{S3AFileStatus#finishWrite}} for every file.
* {{DynamoDBMetadataStore}} should have a {{getTableName()}} or {{getTable()}}.
The table name is parsed within {{initialize()}}, so from the caller (i.e., CLI
tool) point of view, it is difficult to get the table name to call
{{deleteTable(String tableName);}}.
* For {{authoritative()}}, do you think storing it as a flag in the DynamoDB is
a good idea?
> S3Guard: Implement DynamoDBMetadataStore.
> -----------------------------------------
>
> Key: HADOOP-13449
> URL: https://issues.apache.org/jira/browse/HADOOP-13449
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Chris Nauroth
> Assignee: Mingliang Liu
> Attachments: HADOOP-13449-HADOOP-13345.000.patch
>
>
> Provide an implementation of the metadata store backed by DynamoDB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
