[
https://issues.apache.org/jira/browse/HADOOP-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748972#comment-15748972
]
churro morales commented on HADOOP-13578:
-----------------------------------------
fair enough, thats an easy check to make instead of checking if (finish) in the
ZStandardCompressor.c we can just do a if (finish && input.size == input.pos)
which will ensure we have at least compressed everything in the input buffer
before writing the final frame.
Here is what is included in the updated patch:
Fixed the zstd buffer constant naming.
Fixed the constructor for ZStandardCompressor
Removed finished from the ZStandardDirectDecompressor.
Reverted the finished logic in the ZStandardCompressor back to its original
state
return after we throw in any c code.
Parameterized the inflateBytes method such that we don't have to slice the
buffer anymore.
Took care of the endStream with data still left in the buffer
Also fixed the remaining checkstyle issues.
> Add Codec for ZStandard Compression
> -----------------------------------
>
> Key: HADOOP-13578
> URL: https://issues.apache.org/jira/browse/HADOOP-13578
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: churro morales
> Assignee: churro morales
> Attachments: HADOOP-13578.patch, HADOOP-13578.v1.patch,
> HADOOP-13578.v2.patch, HADOOP-13578.v3.patch, HADOOP-13578.v4.patch,
> HADOOP-13578.v5.patch, HADOOP-13578.v6.patch
>
>
> ZStandard: https://github.com/facebook/zstd has been used in production for 6
> months by facebook now. v1.0 was recently released. Create a codec for this
> library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
