[ 
https://issues.apache.org/jira/browse/HADOOP-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749570#comment-15749570
 ] 

Jason Lowe commented on HADOOP-13578:
-------------------------------------

One more thing I just thought of -- if we end up having to loop around and call 
endStream more than once, is it OK that we called ZSTD_compressStream between 
the two calls to ZSTD_endStream?  The call will be degenerate with input size 
== 0, but I'm wondering if that's OK from the zstd lib API perspective.

Actually I think we're OK here since ZSTD_endStream will do a similar 
degenerate ZSTD_compressStream call internally if it isn't in the final 
compression stage, and it looks like ZSTD_compressStream explicitly does 
nothing if the compressor is in the final stage.  So I think we're good, but 
it'd be great if you could double-check.

> Add Codec for ZStandard Compression
> -----------------------------------
>
>                 Key: HADOOP-13578
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13578
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: churro morales
>            Assignee: churro morales
>         Attachments: HADOOP-13578.patch, HADOOP-13578.v1.patch, 
> HADOOP-13578.v2.patch, HADOOP-13578.v3.patch, HADOOP-13578.v4.patch, 
> HADOOP-13578.v5.patch, HADOOP-13578.v6.patch, HADOOP-13578.v7.patch, 
> HADOOP-13578.v8.patch
>
>
> ZStandard: https://github.com/facebook/zstd has been used in production for 6 
> months by facebook now.  v1.0 was recently released.  Create a codec for this 
> library.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to