[
https://issues.apache.org/jira/browse/HADOOP-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940953#comment-15940953
]
Hanisha Koneru commented on HADOOP-14233:
-----------------------------------------
Thank you [~jeagles]. The patch LGTM.
It would be good to follow this practice for logging as well. Passing
concatenated strings into a logging method can also incur a needless
performance hit because the concatenation will be performed every time the
method is called, whether or not the log level is set low enough to show the
message.
> Delay construction of PreCondition.check failure message in Configuration#set
> -----------------------------------------------------------------------------
>
> Key: HADOOP-14233
> URL: https://issues.apache.org/jira/browse/HADOOP-14233
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: HADOOP-14233.1.patch
>
>
> The String in the precondition check is constructed prior to failure
> detection. Since the normal case is no error, we can gain performance by
> delaying the construction of the string until the failure is detected.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
