[ 
https://issues.apache.org/jira/browse/HADOOP-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979881#comment-15979881
 ] 

Steve Loughran commented on HADOOP-14233:
-----------------------------------------

[~andrew.wang] should we have a policy here these days, like revert-and-reapply 
if the commit message is missing a JIRA *or has the wrong one*?

> Delay construction of PreCondition.check failure message in Configuration#set
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-14233
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14233
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>             Fix For: 2.9.0, 2.8.1, 3.0.0-alpha3
>
>         Attachments: HADOOP-14233.1.patch
>
>
> The String in the precondition check is constructed prior to failure 
> detection. Since the normal case is no error, we can gain performance by 
> delaying the construction of the string until the failure is detected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to