[ https://issues.apache.org/jira/browse/HADOOP-14637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081150#comment-16081150 ]
Daniel Templeton commented on HADOOP-14637: ------------------------------------------- Yeah, I missed the actual bug. :) My point was that the precondition is throwing an exception if the wait time is less than the interval, but that only makes sense if the wait time is a multiple of the interval. The scenario you described is the same in any case where that's not true. Ex: wait=110, interval=100 => try, sleep, try, sleep, throw exception. The final test before giving up is required regardless of whether the precondition is removed. > After HADOOP-14568, TestRMRestart.testRMRestartWaitForPreviousAMToFinish() > fails with IllegalArgumentException > -------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-14637 > URL: https://issues.apache.org/jira/browse/HADOOP-14637 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.0.0-alpha4 > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Labels: newbie > Attachments: HADOOP-14637.001.patch, HADOOP-14637.002.patch > > > {noformat} > org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart > testRMRestartWaitForPreviousAMToFinish(org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart) > Time elapsed: 23.718 sec <<< ERROR! > java.lang.IllegalArgumentException: Total wait time should be greater than > check interval time > at > com.google.common.base.Preconditions.checkArgument(Preconditions.java:88) > at > org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:341) > at > org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartWaitForPreviousAMToFinish(TestRMRestart.java:618) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org