[
https://issues.apache.org/jira/browse/HADOOP-14637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081218#comment-16081218
]
Daniel Templeton commented on HADOOP-14637:
-------------------------------------------
I was just having exactly that internal debate. If the call were being made
programmatically, i.e. with generated wait time and internal, having the check
could cause an unexpected failure. Not really a strong argument, but I can't
come up with any compelling reason to keep the check. The reason to keep it
would be to catch the case where the caller gets confused and thinks the wait
time is the number of retries, but that seems above and beyond for an API. As
long as it's clearly documented, it's on the caller to not be dumb. I don't
know. If you feel strongly either way, consider be swayed.
> After HADOOP-14568, TestRMRestart.testRMRestartWaitForPreviousAMToFinish()
> fails with IllegalArgumentException
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-14637
> URL: https://issues.apache.org/jira/browse/HADOOP-14637
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha4
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Labels: newbie
> Attachments: HADOOP-14637.001.patch, HADOOP-14637.002.patch
>
>
> {noformat}
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
> testRMRestartWaitForPreviousAMToFinish(org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart)
> Time elapsed: 23.718 sec <<< ERROR!
> java.lang.IllegalArgumentException: Total wait time should be greater than
> check interval time
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
> at
> org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:341)
> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartWaitForPreviousAMToFinish(TestRMRestart.java:618)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
