[ 
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347064#comment-16347064
 ] 

Elek, Marton commented on HADOOP-15007:
---------------------------------------

As the tags are used only to classify configuration for end user and no strict 
programmatic meaning, I propose the following simplification:

 * I think the PropertyTag enum could be removed (with all of the children)

 * I would use just simple strings as tags

 * We will loose type safety, but it's not a big deal as the tags are not used 
in the code. We don't need constants.

 * With simple string based tags we don't need to care about the dependency and 
compatibility problems. They would be solved.

 * To avoid typo bugs: I would extend the TestConfigurationFieldsBase to check 
the available tags and throw an error if a tag is used less than 3 times.

> Stabilize and document Configuration <tag> element
> --------------------------------------------------
>
>                 Key: HADOOP-15007
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15007
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.1.0
>            Reporter: Steve Loughran
>            Assignee: Anu Engineer
>            Priority: Blocker
>
> HDFS-12350 (moved to HADOOP-15005). Adds the ability to tag properties with a 
> <tag> value.
> We need to make sure that this feature is backwards compatible & usable in 
> production. That's docs, testing, marshalling etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to