[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352138#comment-16352138
]
Elek, Marton commented on HADOOP-15007:
---------------------------------------
+1 for separaing action item 3.
+0 for action item 1 and 2. (This is not my personal preference but don't
thinks it's a big deal, let's do it in any way.) My preference is:
# Don't use tags in the code at all
# Use enums to represent tags
# Use string constants to represent tags
I agree with Anu that 2 is better then 3 and I agree we Steve that 1 is better
then 2.
Just one additional note about a potential use case. I can imagine that some
user would like to introduce custom tags for the configuration values (eg.
MY_UPGRADE_TEST). I think it's usefull, they can mark specific configuration
keys with a specific tag. With the "log at the first time" method the user will
have a a warning/error for every custom tag. Maybe it's also not a big deal but
I think it's a real use-case and in this case we don't need logging at all.
In fact I wouldn't like to see any tag related log. Tags are maintained by the
developer (except the previous use case). I wouldn't like to see any warnings
during my cluster startup as there are no problems with my cluster even if the
tags are misspelled. The warning should be displayed during the build time for
he developers/reviewers.
But again, I can live together with the existing solution, I just tried to
propose a simplification.
> Stabilize and document Configuration <tag> element
> --------------------------------------------------
>
> Key: HADOOP-15007
> URL: https://issues.apache.org/jira/browse/HADOOP-15007
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 3.1.0
> Reporter: Steve Loughran
> Assignee: Ajay Kumar
> Priority: Blocker
>
> HDFS-12350 (moved to HADOOP-15005). Adds the ability to tag properties with a
> <tag> value.
> We need to make sure that this feature is backwards compatible & usable in
> production. That's docs, testing, marshalling etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
