[ https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366512#comment-16366512 ]
Anu Engineer commented on HADOOP-15007: --------------------------------------- [~ajayydv] Overall it looks very good. Some minor comments/questions. # Since we have the hadoop.system.tags in core-default.xml, do we need {{public static final String HADOOP_SYSTEM_TAGS_DEFAULT =}} in {{CommonConfigurationKeysPublic.java}} # Not sure why we callthe {{removeUndeclaredTags}}, if we don't do that we get custom tag support right? Am I missing something here? > Stabilize and document Configuration <tag> element > -------------------------------------------------- > > Key: HADOOP-15007 > URL: https://issues.apache.org/jira/browse/HADOOP-15007 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Affects Versions: 3.2.0 > Reporter: Steve Loughran > Assignee: Ajay Kumar > Priority: Blocker > Attachments: HADOOP-15007.000.patch, HADOOP-15007.001.patch > > > HDFS-12350 (moved to HADOOP-15005). Adds the ability to tag properties with a > <tag> value. > We need to make sure that this feature is backwards compatible & usable in > production. That's docs, testing, marshalling etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org