[
https://issues.apache.org/jira/browse/HADOOP-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033352#comment-13033352
]
John George commented on HADOOP-7282:
-------------------------------------
Ran manual tests to verify that ip address gets printed out correctly even when
client exits without completing an rpc.
Also ran tests to verify that ip gets printed in normal use cases.
No tests attached since it seemed extremely difficult to add tests for the
above use-cases.
Results of test-patch. findbugs not because of this patch.
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs
(version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
[exec]
[exec]
~
> getRemoteIp could return null in cases where the call is ongoing but the ip
> went away.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7282
> URL: https://issues.apache.org/jira/browse/HADOOP-7282
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Fix For: 0.23.0
>
> Attachments: HADOOP-7282-1.patch, HADOOP-7282.patch, diffs.txt
>
>
> getRemoteIp gets the ip from socket instead of the stored ip in Connection
> object. Thus calls to this function could return null when a client
> disconnected, but the rpc call is still ongoing...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
