[
https://issues.apache.org/jira/browse/HADOOP-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034562#comment-13034562
]
Hadoop QA commented on HADOOP-7282:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479182/HADOOP-7282-1.patch
against trunk revision 1103971.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//console
This message is automatically generated.
> getRemoteIp could return null in cases where the call is ongoing but the ip
> went away.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7282
> URL: https://issues.apache.org/jira/browse/HADOOP-7282
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Fix For: 0.23.0
>
> Attachments: HADOOP-7282-1.patch, HADOOP-7282.patch, diffs.txt
>
>
> getRemoteIp gets the ip from socket instead of the stored ip in Connection
> object. Thus calls to this function could return null when a client
> disconnected, but the rpc call is still ongoing...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
