[
https://issues.apache.org/jira/browse/HADOOP-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038599#comment-13038599
]
Hadoop QA commented on HADOOP-7208:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480249/HADOOP-7208-2.patch
against trunk revision 1126719.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/514//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/514//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/514//console
This message is automatically generated.
> equals() and hashCode() implementation need to change in StandardSocketFactory
> ------------------------------------------------------------------------------
>
> Key: HADOOP-7208
> URL: https://issues.apache.org/jira/browse/HADOOP-7208
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7208-2.patch, HADOOP-7208.patch
>
>
> In Hadoop IPC Client, we are using ClientCache which will maintain the
> HashMap to keep the Client references.
> private Map<SocketFactory, Client> clients =
> new HashMap<SocketFactory, Client>();
> Now let us say, we want use two standard factories with Hadoop.
> MyStandardSocketFactory (which extends StandardSocketFactory), and
> StandardSocketFactory. In this case, because of equals and hashcode
> implementation, MyStandardSocketFactory client can be overridden by
> StandardSocketFactoryClient
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
