[ https://issues.apache.org/jira/browse/HADOOP-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040983#comment-13040983 ]
Todd Lipcon commented on HADOOP-7208: ------------------------------------- - There are still hard tabs in this patch. - there is no contract that hashCode() has to differ if two objects are unequal -- so your unit test there is not valid - for the implementation of hashcode, might as well use getClass().hashCode() -- you don't need to get the class name > equals() and hashCode() implementation need to change in StandardSocketFactory > ------------------------------------------------------------------------------ > > Key: HADOOP-7208 > URL: https://issues.apache.org/jira/browse/HADOOP-7208 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.23.0 > Reporter: Uma Maheswara Rao G > Assignee: Uma Maheswara Rao G > Fix For: 0.23.0 > > Attachments: HADOOP-7208-2.patch, HADOOP-7208.patch > > > In Hadoop IPC Client, we are using ClientCache which will maintain the > HashMap to keep the Client references. > private Map<SocketFactory, Client> clients = > new HashMap<SocketFactory, Client>(); > Now let us say, we want use two standard factories with Hadoop. > MyStandardSocketFactory (which extends StandardSocketFactory), and > StandardSocketFactory. In this case, because of equals and hashcode > implementation, MyStandardSocketFactory client can be overridden by > StandardSocketFactoryClient -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira