[ https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570685#comment-16570685 ]
Thomas Marquardt commented on HADOOP-15546: ------------------------------------------- I'm back from paternity leave. Sorry for the long pause. The preview of ABFS shared many of the same config property names as WASB, and we now have a lot of customers using them. I agree that we need to improve the configuration, make it easier to use, and easier to troubleshoot (better error handling). However, we cannot remove or rename the current config properties without breaking our customers. I spoke with Steve about this on a phone call this morning, and would like you to make a list of the changes you'd like to see regarding configuration and we will work on them in a separate JIRA. For now, I'd like to revert back to using two test configuration files, one for WASB and one for ABFS. I promise we will improve the situation, but I want to do it right, and need sometime to think thru it. I don't want to block progress in the meantime. So our primary goal is to stabilize ABFS (get all the tests passing, bugs fixed, etc), and then we can fix the config issue. ABFS was originally designed to replace WASB, which is why it uses the same config. The idea was that users would simply replace the class mapping for the WASB scheme, and they'd suddenly be using the new ABFS code. We have since realized that ABFS needs to be independent of WASB, allow WASB to be an option, even though it will be deprecated and all future development work will target ABFS. So we will think about this and come up with a way to onboard customers to a better config solution for ABFS, but for now please do not remove/rename or change the behavior of existing config keys, as this will break customers. > ABFS: tune imports & javadocs; stabilise tests > ---------------------------------------------- > > Key: HADOOP-15546 > URL: https://issues.apache.org/jira/browse/HADOOP-15546 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: HADOOP-15407 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Major > Attachments: HADOOP-15546-001.patch, > HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch, > HADOOP-15546-HADOOP-15407-003.patch, HADOOP-15546-HADOOP-15407-004.patch, > HADOOP-15546-HADOOP-15407-005.patch, HADOOP-15546-HADOOP-15407-006.patch, > HADOOP-15546-HADOOP-15407-006.patch, HADOOP-15546-HADOOP-15407-007.patch, > HADOOP-15546-HADOOP-15407-008.patch, azure-auth-keys.xml > > > Followup on HADOOP-15540 with some initial review tuning > h2. Tuning > * ordering of imports > * rely on azure-auth-keys.xml to store credentials (change imports, > docs,.gitignore) > * log4j -> info > * add a "." to the first sentence of all the javadocs I noticed. > * remove @Public annotations except for some constants (which includes some > commitment to maintain them). > * move the AbstractFS declarations out of the src/test/resources XML file > into core-default.xml for all to use > * other IDE-suggested tweaks > h2. Testing > Review the tests, move to ContractTestUtil assertions, make more consistent > to contract test setup, and general work to make the tests work well over > slower links, document, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org