anuengineer commented on a change in pull request #798: HDDS-1499. OzoneManager
Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r282164337
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStore.java
##########
@@ -44,17 +45,20 @@
*/
Table<byte[], byte[]> getTable(String name) throws IOException;
+
/**
* Gets an existing TableStore with implicit key/value conversion.
*
* @param name - Name of the TableStore to get
* @param keyType
* @param valueType
+ * @param cachetype - Type of cache need to be used for this table.
* @return - TableStore.
* @throws IOException on Failure
*/
<KEY, VALUE> Table<KEY, VALUE> getTable(String name,
- Class<KEY> keyType, Class<VALUE> valueType) throws IOException;
+ Class<KEY> keyType, Class<VALUE> valueType,
+ TableCache.CACHETYPE cachetype) throws IOException;
Review comment:
Why do we need an external visible TableCache.CACHETYPE ? shouldn't this be
an implementation detail of the Tables that have Cache?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
