anuengineer commented on a change in pull request #798: HDDS-1499. OzoneManager 
Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r282164867
 
 

 ##########
 File path: 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/Table.java
 ##########
 @@ -97,6 +102,28 @@ void putWithBatch(BatchOperation batch, KEY key, VALUE 
value)
    */
   String getName() throws IOException;
 
+  /**
+   * Add entry to the table cache.
+   *
+   * If the cacheKey already exists, it will override the entry.
+   * @param cacheKey
+   * @param cacheValue
+   */
 
 Review comment:
   well, I was really hoping that the fact that there is a cache is not visible 
to the layer that is reading and writing.
   Is there a reason why that should be exposed to calling applications?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to