hanishakoneru commented on a change in pull request #956: HDDS-1638. Implement Key Write Requests to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/956#discussion_r296069181
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java ########## @@ -0,0 +1,193 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.request.key; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +import com.google.common.base.Optional; +import com.google.common.base.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hadoop.ozone.audit.AuditLogger; +import org.apache.hadoop.ozone.audit.OMAction; +import org.apache.hadoop.ozone.om.OMMetadataManager; +import org.apache.hadoop.ozone.om.OMMetrics; +import org.apache.hadoop.ozone.om.OzoneManager; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.om.helpers.OmKeyInfo; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; +import org.apache.hadoop.ozone.om.request.OMClientRequest; +import org.apache.hadoop.ozone.om.response.OMClientResponse; +import org.apache.hadoop.ozone.om.response.key.OMKeyCommitResponse; +import org.apache.hadoop.ozone.om.response.key.OMKeyCreateResponse; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .CommitKeyRequest; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .CommitKeyResponse; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .KeyArgs; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos + .OMRequest; +import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer; +import org.apache.hadoop.ozone.security.acl.OzoneObj; +import org.apache.hadoop.util.Time; +import org.apache.hadoop.utils.db.cache.CacheKey; +import org.apache.hadoop.utils.db.cache.CacheValue; + + + + +import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.KEY_NOT_FOUND; + +/** + * Handles CommitKey request. + */ +public class OMKeyCommitRequest extends OMClientRequest + implements OMKeyRequest { + + private static final Logger LOG = + LoggerFactory.getLogger(OMKeyCommitRequest.class); + + public OMKeyCommitRequest(OMRequest omRequest) { + super(omRequest); + } + + @Override + public OMRequest preExecute(OzoneManager ozoneManager) throws IOException { + CommitKeyRequest commitKeyRequest = getOmRequest().getCommitKeyRequest(); + Preconditions.checkNotNull(commitKeyRequest); + + KeyArgs keyArgs = commitKeyRequest.getKeyArgs(); + + KeyArgs.Builder newKeyArgs = + keyArgs.toBuilder().setModificationTime(Time.now()); + + return getOmRequest().toBuilder() + .setCommitKeyRequest(commitKeyRequest.toBuilder() + .setKeyArgs(newKeyArgs)).setUserInfo(getUserInfo()).build(); + + } + + @Override + public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, + long transactionLogIndex) { + + CommitKeyRequest commitKeyRequest = getOmRequest().getCommitKeyRequest(); + Preconditions.checkNotNull(commitKeyRequest); + + KeyArgs commitKeyArgs = commitKeyRequest.getKeyArgs(); + + String volumeName = commitKeyArgs.getVolumeName(); + String bucketName = commitKeyArgs.getBucketName(); + String keyName = commitKeyArgs.getKeyName(); + + OMMetrics omMetrics = ozoneManager.getMetrics(); + omMetrics.incNumKeyCommits(); + + AuditLogger auditLogger = ozoneManager.getAuditLogger(); + + Map<String, String> auditMap = buildKeyArgsAuditMap(commitKeyArgs); + + OzoneManagerProtocolProtos.OMResponse.Builder omResponse = + OzoneManagerProtocolProtos.OMResponse.newBuilder().setCmdType( + OzoneManagerProtocolProtos.Type.CommitKey).setStatus( + OzoneManagerProtocolProtos.Status.OK).setSuccess(true); + + try { + // check Acl + if (ozoneManager.getAclsEnabled()) { + checkAcls(ozoneManager, OzoneObj.ResourceType.KEY, + OzoneObj.StoreType.OZONE, IAccessAuthorizer.ACLType.WRITE, + volumeName, bucketName, keyName); + } + } catch (IOException ex) { + LOG.error("CommitKey failed for Key: {} in volume/bucket:{}/{}", + keyName, bucketName, volumeName, ex); + omMetrics.incNumKeyCommitFails(); + auditLog(auditLogger, buildAuditMessage(OMAction.COMMIT_KEY, auditMap, + ex, getOmRequest().getUserInfo())); + return new OMKeyCreateResponse(null, -1L, + createErrorOMResponse(omResponse, ex)); + } + + List<OmKeyLocationInfo> locationInfoList = commitKeyArgs + .getKeyLocationsList().stream().map(OmKeyLocationInfo::getFromProtobuf) + .collect(Collectors.toList()); + + OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager(); + String dbOzoneKey = omMetadataManager.getOzoneKey(volumeName, bucketName, + keyName); + String dbOpenKey = omMetadataManager.getOpenKey(volumeName, bucketName, + keyName, commitKeyRequest.getClientID()); + + omMetadataManager.getLock().acquireBucketLock(volumeName, bucketName); Review comment: Locks should be acquired inside the try block. This needs to be fixed in all the OM Requests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
