hanishakoneru commented on a change in pull request #956: HDDS-1638. Implement Key Write Requests to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/956#discussion_r296418990
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ########## @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.request.key; + +import com.google.common.base.Preconditions; +import org.apache.hadoop.crypto.key.KeyProviderCryptoExtension + .EncryptedKeyVersion; +import org.apache.hadoop.fs.CommonConfigurationKeys; +import org.apache.hadoop.fs.FileEncryptionInfo; +import org.apache.hadoop.hdds.client.BlockID; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.scm.container.common.helpers.AllocatedBlock; +import org.apache.hadoop.hdds.scm.container.common.helpers.ExcludeList; +import org.apache.hadoop.hdds.scm.exceptions.SCMException; +import org.apache.hadoop.ipc.Server; +import org.apache.hadoop.ozone.om.OMMetadataManager; +import org.apache.hadoop.ozone.om.OzoneManager; +import org.apache.hadoop.ozone.om.ScmClient; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.om.helpers.BucketEncryptionKeyInfo; +import org.apache.hadoop.ozone.om.helpers.OmBucketInfo; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; +import org.apache.hadoop.ozone.security.OzoneBlockTokenSecretManager; +import org.apache.hadoop.security.SecurityUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.security.GeneralSecurityException; +import java.security.PrivilegedExceptionAction; +import java.util.ArrayList; +import java.util.EnumSet; +import java.util.List; + +import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes + .BUCKET_NOT_FOUND; +import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes + .VOLUME_NOT_FOUND; +import static org.apache.hadoop.util.Time.monotonicNow; + +/** + * Interface for key write requests. + */ +public interface OMKeyRequest { + + Logger LOG = LoggerFactory.getLogger(OMKeyRequest.class); + + /** + * This methods avoids multiple rpc calls to SCM by allocating multiple blocks + * in one rpc call. + * @throws IOException + */ + @SuppressWarnings("parameternumber") + default List< OmKeyLocationInfo > allocateBlock(ScmClient scmClient, + OzoneBlockTokenSecretManager secretManager, + HddsProtos.ReplicationType replicationType, + HddsProtos.ReplicationFactor replicationFactor, + ExcludeList excludeList, long requestedSize, long scmBlockSize, + int preallocateBlocksMax, boolean grpcBlockTokenEnabled, String omID) + throws IOException { + + int numBlocks = Math.min((int) ((requestedSize - 1) / scmBlockSize + 1), + preallocateBlocksMax); + + List<OmKeyLocationInfo> locationInfos = new ArrayList<>(numBlocks); + String remoteUser = getRemoteUser().getShortUserName(); + List<AllocatedBlock> allocatedBlocks; + try { + allocatedBlocks = scmClient.getBlockClient() + .allocateBlock(scmBlockSize, numBlocks, replicationType, + replicationFactor, omID, excludeList); + } catch (SCMException ex) { + if (ex.getResult() + .equals(SCMException.ResultCodes.SAFE_MODE_EXCEPTION)) { + throw new OMException(ex.getMessage(), + OMException.ResultCodes.SCM_IN_SAFE_MODE); + } + throw ex; + } + for (AllocatedBlock allocatedBlock : allocatedBlocks) { + OmKeyLocationInfo.Builder builder = new OmKeyLocationInfo.Builder() + .setBlockID(new BlockID(allocatedBlock.getBlockID())) + .setLength(scmBlockSize) + .setOffset(0) + .setPipeline(allocatedBlock.getPipeline()); + if (grpcBlockTokenEnabled) { + builder.setToken(secretManager + .generateToken(remoteUser, allocatedBlock.getBlockID().toString(), + getAclForUser(remoteUser), scmBlockSize)); + } + locationInfos.add(builder.build()); + } + return locationInfos; + } + + /* Optimize ugi lookup for RPC operations to avoid a trip through + * UGI.getCurrentUser which is synch'ed. + */ + default UserGroupInformation getRemoteUser() throws IOException { + UserGroupInformation ugi = Server.getRemoteUser(); + return (ugi != null) ? ugi : UserGroupInformation.getCurrentUser(); + } + + /** + * Return acl for user. + * @param user + * + * */ + default EnumSet< HddsProtos.BlockTokenSecretProto.AccessModeProto> + getAclForUser(String user) { + // TODO: Return correct acl for user. + return EnumSet.allOf( + HddsProtos.BlockTokenSecretProto.AccessModeProto.class); + } + + /** + * Validate bucket and volume exists or not. + * @param omMetadataManager + * @param volumeName + * @param bucketName + * @throws IOException + */ + default void validateBucket(OMMetadataManager omMetadataManager, + String volumeName, String bucketName) Review comment: Should this be renamed to validateBucketAndVolume as both are validated here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
