bharatviswa504 commented on a change in pull request #1277: HDDS-1054. List Multipart uploads in a bucket URL: https://github.com/apache/hadoop/pull/1277#discussion_r320407326
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ########## @@ -1270,6 +1271,58 @@ public void abortMultipartUpload(OmKeyArgs omKeyArgs) throws IOException { } + @Override + public OmMultipartUploadList listMultipartUploads(String volumeName, + String bucketName, String prefix) throws OMException { + Preconditions.checkNotNull(volumeName); + Preconditions.checkNotNull(bucketName); Review comment: prefix also should not be null. As prefix is also required in ListMultipartUploadRequest in proto. And also here we using "+" for concatentation, so if we pass null for prefix, then it will be /volume/bucket/null. The below method is called by getMultipartUploadKeys. public static String getDbKey(String volume, String bucket, String key) { return OM_KEY_PREFIX + volume + OM_KEY_PREFIX + bucket + OM_KEY_PREFIX + key; } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org