bharatviswa504 commented on a change in pull request #1277: HDDS-1054. List
Multipart uploads in a bucket
URL: https://github.com/apache/hadoop/pull/1277#discussion_r324859826
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java
##########
@@ -52,4 +52,12 @@ public static S3StorageType getDefault() {
return STANDARD;
}
+ public static S3StorageType fromReplicationType(
+ ReplicationType replicationType) {
+ if (replicationType == ReplicationType.STAND_ALONE) {
+ return S3StorageType.REDUCED_REDUNDANCY;
Review comment:
just a question, I think this is before even this patch.
Previously we use STAND_ALONE for replication factor one, now we use RATIS
with one and three. So, I think we need to change the code for this right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
