steveloughran commented on a change in pull request #1707: HADOOP-16697.
Tune/audit auth mode
URL: https://github.com/apache/hadoop/pull/1707#discussion_r354273717
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInstrumentation.java
##########
@@ -1172,10 +1181,25 @@ public void recordsRead(int count) {
* records have been written (including deleted).
* @param count number of records written.
*/
+ @Override
public void recordsWritten(int count) {
incrementCounter(S3GUARD_METADATASTORE_RECORD_WRITES, count);
}
+ @Override
+ public void directoryMarkedAuthoritative() {
+ incrementCounter(S3GUARD_METADATASTORE_AUTHORITATIVE_DIRECTORIES_UPDATED,
+ 1);
+ }
+
+ @Override
+ public void entryAdded(final long durationNanos) {
+ addValueToQuantiles(
+ S3GUARD_METADATASTORE_PUT_PATH_LATENCY,
+ durationNanos);
+ incrementCounter(S3GUARD_METADATASTORE_PUT_PATH_REQUEST, 1);
Review comment:
It's called in S3Guard.putAndReturn. This is it today
```
instrumentation.addValueToQuantiles(
S3GUARD_METADATASTORE_PUT_PATH_LATENCY,
(System.nanoTime() - startTimeNano));
instrumentation.incrementCounter(
S3GUARD_METADATASTORE_PUT_PATH_REQUEST,
1);
```
All I'm doing is moving it into the metastore instrumentation. Therefore:
this patch is consistent with today's use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
