steveloughran commented on a change in pull request #1707: HADOOP-16697.
Tune/audit auth mode
URL: https://github.com/apache/hadoop/pull/1707#discussion_r362561542
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java
##########
@@ -177,23 +173,40 @@ public static S3AFileStatus putAndReturn(MetadataStore
ms,
public static S3AFileStatus putAndReturn(
final MetadataStore ms,
final S3AFileStatus status,
- final S3AInstrumentation instrumentation,
final ITtlTimeProvider timeProvider,
@Nullable final BulkOperationState operationState) throws IOException {
long startTimeNano = System.nanoTime();
try {
putWithTtl(ms, new PathMetadata(status), timeProvider, operationState);
} finally {
- instrumentation.addValueToQuantiles(
- S3GUARD_METADATASTORE_PUT_PATH_LATENCY,
- (System.nanoTime() - startTimeNano));
- instrumentation.incrementCounter(
- S3GUARD_METADATASTORE_PUT_PATH_REQUEST,
- 1);
+ ms.getInstrumentation().entryAdded((System.nanoTime() - startTimeNano));
}
return status;
}
+ /**
+ * Creates an authoritative directory marker for the store.
+ * @param ms MetadataStore to {@code put()} into.
+ * @param status status to store
+ * @param timeProvider Time provider to use when writing entries
+ * @param operationState possibly-null metastore state tracker.
+ * @throws IOException if metadata store update failed
+ */
+ @RetryTranslated
+ public static void putAuthDirectoryMarker(
+ final MetadataStore ms,
+ final S3AFileStatus status,
+ final ITtlTimeProvider timeProvider,
+ @Nullable final BulkOperationState operationState) throws IOException {
+ long startTimeNano = System.nanoTime();
Review comment:
something to think about. the new abfs perf measurement goes that way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
