liuml07 commented on a change in pull request #1761: HADOOP-16759. Filesystem
openFile() builder to take a FileStatus param
URL: https://github.com/apache/hadoop/pull/1761#discussion_r357769429
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
##########
@@ -2924,16 +2924,19 @@ protected FSDataInputStreamBuilder(
@Override
public CompletableFuture<FSDataInputStream> build() throws IOException {
final Path absF = fixRelativePart(getPath());
+ OpenFileParameters parameters = new OpenFileParameters();
+ parameters.setMandatoryKeys(getMandatoryKeys());
+ parameters.setOptions(getOptions());
+ parameters.setBufferSize(getBufferSize());
+ parameters.setStatus(getStatus());
return new FSLinkResolver<CompletableFuture<FSDataInputStream>>() {
@Override
public CompletableFuture<FSDataInputStream> next(
final AbstractFileSystem fs,
final Path p)
throws IOException {
return fs.openFileWithOptions(p,
- getMandatoryKeys(),
- getOptions(),
- getBufferSize());
+ parameters);
Review comment:
nit: merge with previous line seems no longer than 80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
