liuml07 commented on a change in pull request #1761: HADOOP-16759. Filesystem
openFile() builder to take a FileStatus param
URL: https://github.com/apache/hadoop/pull/1761#discussion_r357790680
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -4366,15 +4378,38 @@ private void requireSelectSupport(final Path source)
throws
InternalConstants.STANDARD_OPENFILE_KEYS,
"for " + path + " in non-select file I/O");
}
+ FileStatus status = parameters.getStatus();
Review comment:
nit: This `status` can be named `providedStatus` or something. Clearer as
it's referred multiple times following.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
