snvijaya commented on a change in pull request #1790: changes for combined
append+flush calls for blockblob(traditionan) an…
URL: https://github.com/apache/hadoop/pull/1790#discussion_r363151516
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java
##########
@@ -146,6 +150,10 @@
DefaultValue = DEFAULT_ENABLE_FLUSH)
private boolean enableFlush;
+ @BooleanConfigurationValidatorAnnotation(ConfigurationKey =
FS_AZURE_ENABLE_APPEND_WITH_FLUSH,
+ DefaultValue = DEFAULT_ENABLE_APPEND_WITH_FLUSH)
+ private boolean enableAppendWithFlush;
Review comment:
This config value is passed until AbfsOutputStream.java ->
writeCurrentBufferToService() as the first argument. but no specific action is
seen inside writeCurrentBufferToService() if the value is true or false.
What is intended of this config ? is it required ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
