snvijaya commented on a change in pull request #1790: changes for combined
append+flush calls for blockblob(traditionan) an…
URL: https://github.com/apache/hadoop/pull/1790#discussion_r363151653
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java
##########
@@ -130,6 +130,10 @@
DefaultValue = DEFAULT_FS_AZURE_ATOMIC_RENAME_DIRECTORIES)
private String azureAtomicDirs;
+ @StringConfigurationValidatorAnnotation(ConfigurationKey =
FS_AZURE_APPEND_BLOB_KEY,
+ DefaultValue = DEFAULT_FS_AZURE_APPEND_BLOB_DIRECTORIES)
+ private String azureAppendBlobDirs;
Review comment:
New configs need documentation. For reference, recent documentation done for
flush related config :
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/site/markdown/abfs.md#-flush-options
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
